Improve logging when handling users and institutions#236
Open
Improve logging when handling users and institutions#236
Conversation
phavekes
force-pushed
the
feature/Improve_loging
branch
2 times, most recently
from
107ce86 to
b6da62a
Compare
phavekes
force-pushed
the
feature/Improve_loging
branch
2 times, most recently
from
d773919 to
c5a3049
Compare
kayjoosten
force-pushed
the
feature/Improve_loging
branch
from
c660136 to
8a1a9d3
Compare
The test where failing as the complexity of the function became to big. Therefore, some logic had to be moved to a private function.
kayjoosten
force-pushed
the
feature/Improve_loging
branch
from
8a1a9d3 to
0029638
Compare
phavekes
requested review from
johanib and
pmeulen
and removed request for
johanib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding the automatic metadata updates, the logging on invalid signatures was removed.
Added context to log messages on users and institutions